Comments on: Adding Items to the Status Bar

By: Scotty

Scotty — Mon, 09 Mar 2009 11:15:39 +0000

The code in the video does miss the statusItem=nil out.
I have added a note to the video to point this out.
The sample code that comes with the course in however is (and always has been) correct and does contain the missing line.

By: Kevin Yank

Kevin Yank — Mon, 09 Mar 2009 02:16:36 +0000

As craibuc has pointed out, there is a glaring bug in this example. In the removeStatusItem method, statusItem is released, but it is not set to nil. As a result, the next call to buttonClicked results in removeStatusItem being triggered again, and the program crashing.

Here is the corrected code for removeStatusItem:

- (void) removeStatusItem
{
[[NSStatusBar systemStatusBar] removeStatusItem:statusItem];
[statusItem release];
statusItem = nil; // THIS LINE ADDED TO PREVENT CRASH
[button setTitle:@"Add Status Item"];
}

By: craibuc

craibuc — Wed, 11 Feb 2009 21:43:39 +0000

looks like the statusItem = nil; line was not mentioned in the video, but is in the source.

By: craibuc

craibuc — Wed, 11 Feb 2009 21:18:52 +0000

Thanks, I enjoyed the tutorial.

I think there is an error w/ the code. If you add a statusItem, remove it, then try to add it again, the [self removeStatusItem] message is executed. Are you certain that (statusItem == nil) is right test?